Skip to content

Added Multimedia Video and Display GStreamer test scripts#290

Open
nitinn22 wants to merge 7 commits intoqualcomm-linux:mainfrom
nitinn22:feature/gstchange
Open

Added Multimedia Video and Display GStreamer test scripts#290
nitinn22 wants to merge 7 commits intoqualcomm-linux:mainfrom
nitinn22:feature/gstchange

Conversation

@nitinn22
Copy link

The scripts support GStreamer level validation for video and display,

Video: H.264/H.265/VP9 encode/decode with V4L2
Display: Wayland compositor validation

More info in their corresponding readme files.

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
…sing

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the generic helpers currently defined in Video_Encode_Decode/run.sh into Runner/utils/lib_gstreamer.sh so other GST tests can reuse them:
get_resolution_params() ->gstreamer_resolution_to_wh()
get_encoder_element() / get_decoder_element() -> gstreamer_v4l2_{encoder,decoder}_for_codec()
get_file_extension() -> gstreamer_container_ext_for_codec() (or similar)
Extract pipeline string creation into library builders:
gstreamer_build_v4l2_encode_pipeline()
gstreamer_build_v4l2_decode_pipeline()
Move bitrate selection + file-size helper into lib (gstreamer_bitrate_for_resolution, gstreamer_file_size_bytes) to avoid re-implementations.

Keep .res emission + summary logic in run.sh. library functions should not write results directly.

…r V4L2 video helper functions from Video_Encode_Decode test to shared lib_gstreamer.sh for code reuse across all GStreamer tests

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
@smuppand
Copy link
Contributor

@nitinn22 Kindly close the comments where you've already addressed previous review feedback, so I can focus on the remaining ones. Also, please rebase your work on top of the main branch. Also Updated SPDX license identifiers from BSD-3-Clause-Clear to BSD-3-Clause per legal request.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README inconsistency (Waylandsink): help text says default test is “for 10s” but script default duration resolves to 30s. Update README/help examples.

README mismatch (Video): documentation lists encoded outputs like .h264/.h265, but the pipeline uses mp4mux and outputs .mp4. Update README to match reality.

…video scripts based on review comments

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
…l request

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
…omments

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments